Add full UIDevice support [WIP]

GertjanReynaert / react-native-device

A UIDevice class wrapper for React Native

179 stars 34 forks source link

Add full UIDevice support [WIP] #15

Closed GertjanReynaert closed 8 years ago

GertjanReynaert commented 9 years ago

DO NOT MERGE! Still work in progress!

[x] add all possible UIDevice values to exported constants
[x] mark dynamic properties with initial prefix so that it is clear these values don't update
[x] export methods for orientationState, batteryState, batteryLevel and proximityState to manually request new value
[x] implement watch method, so that callback gets called on every value change/native notification
[x] add stopWatching methods, so you can remove the eventlistener

GertjanReynaert commented 9 years ago

@kkjdaniel Would you mind reviewing this pr?

kkjdaniel commented 9 years ago

Lots of changes there! Yeah sure I'll take a look, I'm guessing ideally it should export the events so that the values can be updated in the app and not just at the start of the runtime?

kkjdaniel commented 9 years ago

Been really busy recently, will hopefully get a chance to review this PR and little more today - and I'll look into those remaining features, unless you've already made progress on them?

aliemre commented 8 years ago

@kkjdaniel @GertjanReynaert Is there any update for the PR? Other features of UIDevice is important. I'd be appreciate when it's merged.