search

GetDKAN / data-catalog-app

A Create-React-App version of the default data catalog fronted for DKAN
12 stars 10 forks source link

Translate app with i18next #100

Open alex-ahumada opened 2 years ago

alex-ahumada commented 2 years ago

Please read: https://github.com/GetDKAN/data-catalog-components/pull/164

Frontend translation using i18next, with browser language detection and EN/ES translations. Added translations for page titles and FeaturedDatasets component.

pastanislas commented 6 months ago

Hello, is there a plan to implement this or something else that could help translating the front ? Right now, translating the search placeholder for example is challenging (as least to me ). Thank you for your work and help.

alex-ahumada commented 6 months ago

Hi @pastanislas.

If the DKAN team wants to merge this, I can resolve the conflicts. But I'll need confirmation from their side first. We finally forked the repo and have a live site with i18n enabled.. You can propably check the commits and make the necessary changes in your project.

dafeder commented 6 months ago

Congrats on launching that site @alex-ahumada!

I know its been a while on these PRs but we do intend to get back to them soon. Not sure if you're able to update them so they merge cleanly again; I imagine your fork has diverged a bit but that would be helpful.

FYI we also have a discussion thread going on multilingual FE.

alex-ahumada commented 6 months ago

Thanks for sharing the discussion @dafeder. I'll try to also update this PR after solving https://github.com/GetDKAN/data-catalog-components/pull/164