search

GetDKAN / data-catalog-components

https://getdkan.github.io/data-catalog-components
9 stars 6 forks source link

Translate frontend with i18next #164

Open alex-ahumada opened 2 years ago

alex-ahumada commented 2 years ago

Frontend translation using i18next , with browser language detection and EN/ES translations. We should probably move translations from config file to individual language files when more languages are added.

resolves #78

dafeder commented 2 years ago

Thank you @alex-ahumada! Will review ASAP

alex-ahumada commented 2 years ago

Thanks @dafeder! We should remove debug from i18next config file before release.

alex-ahumada commented 1 year ago

Codeclimete warns about: Similar blocks of code found in 2 locations. Consider refactoring.

That can't be fixed as i18next language config blocks are similar by design.

dafeder commented 4 months ago

@alex-ahumada I know its been a while on these PRs but we do intend to get back to them soon. Not sure if you're able to update them so they merge cleanly again; I imagine your fork has diverged a bit but that would be helpful.

I'm sure we can override that codeclimate gate if that's the only blocker 😄

alex-ahumada commented 4 months ago

I'll try update the fork and resolve the conflicts in the coming days @dafeder !