search

GetDKAN / dkan

DKAN Open Data Portal
https://dkan.readthedocs.io/en/latest/index.html
GNU General Public License v2.0
365 stars 170 forks source link

dkan_datastore_lock set to 1 results in infinite loop / WSOD in Dkan\Datastore\LockableDrupalVariables->getLock() #2836

Open neuronick opened 5 years ago

neuronick commented 5 years ago

If variable dkan_datastore_lock is set to 1 (probably as a result of failed update), this results in infinite loop / WSOD which is extremely difficult to debug, as it doesn't produce any error in logs.

Steps to Reproduce

  1. Run variable_set('dkan_datastore_lock', 1); via Devel PHP
  2. Go to a resource, containing CSV file (local or remote)
  3. There will be infinite loop and a WSOD as a result
kimwdavidson commented 5 years ago

@neuronick Thanks for reporting! We'll take a look at this. In the meantime, if you'd like to submit a pull request, we'll be happy to review it.

grugnog commented 5 years ago

We are working on this in https://github.com/GetDKAN/dkan/pull/2876