search

GetDKAN / dkan

DKAN Open Data Portal
https://dkan.readthedocs.io/en/latest/index.html
GNU General Public License v2.0
373 stars 171 forks source link

Unable to remove a harvest without deleting its datasets #3839

Closed thierrydallacroce closed 7 months ago

thierrydallacroce commented 2 years ago

With the goal of cleaning up an old harvest from an environment where it was mistakenly added and ran, I tested both of the following approaches in a local environment:

drush dkan:harvest:deregister harvest_id

and

drush dkan:harvest:revert harvest_id

But, both deleted the datasets.

stefan-korn commented 1 year ago

@dafeder : Provided a merge request for this as discussed in #3840.

One could probably add some check if there are entities related to the harvest at all and only in that case show the warning and ask for confirmation. But maybe the warning is okay in any case?

There are also some issues with the messages from the deregister comment, which are unrelated to this. See issue #3956. #3840 and #3956 will not apply together. If either of the PRs is accepted, the other will need to be updated.

dafeder commented 7 months ago

@stefan-korn I think we consider this resolved, feel free to re-open if you think it needs more work.