search

GetDKAN / dkan

DKAN Open Data Portal
https://dkan.readthedocs.io/en/latest/index.html
GNU General Public License v2.0
373 stars 171 forks source link

Metastore service needs to call logger.factory #4100

Closed stefan-korn closed 8 months ago

stefan-korn commented 9 months ago

Describe the bug

The metastore service does not output correctly to the log because the logger service is not present.

Steps To Reproduce

for example if this exception is raised, there will be no entry in the log. If you cannot reproduce an exception here, you could just add a log call in the try-part and see that the message is not logged.

Expected behavior

message should be logged.

paul-m commented 8 months ago

Thanks!

In this PR we deprecated LoggerTrait and made sure it was replaced with a more direct service injection: https://github.com/GetDKAN/dkan/pull/4140

I'll close this issue and the associated PR. Feel free to open a new one if you find something else.