Closed swirtSJW closed 1 month ago
I'm unable to reproduce this. I create a new DKAN site and use the sample_content module to create datasets. I visit the revision tab for a dataset and it displays fine, without any errors.
It's entirely possible that there's an edge case we're not testing for here because the coverage report says the code in the Dereferencer
class is not covered. In fact there are two places where we call log()
, and only one has coverage. The Referencer
class has two log()
calls as well, and neither has coverage.
log()
in the Referencer
and Dereferencer
classes.LoggerTrait
deprecation and see if we need coverage/fixes for those, too. https://github.com/GetDKAN/dkan/pull/4140My guess is that it will go away when this https://github.com/GetDKAN/dkan/pull/4217 is merged.
Sorry, I have created a duplicate at #4226 . Closed #4226
Is there an existing issue for this?
Current Behavior
Looking at either the revisions list page or comparing two revisions, there are multiple warnings and deprecation notices.
Expected Behavior
Ought to not see scary bits on the screen.
Steps To Reproduce
Relevant log output
Anything else?
The relevant bit of code in Drupal 10.3 has not changed in 10 yrs https://git.drupalcode.org/project/drupal/-/blob/10.3.x/core/lib/Drupal/Core/Logger/LoggerChannel.php?ref_type=heads&blame=1#L49
The relative bit of code in DKAN changed 3 months ago. https://github.com/GetDKAN/dkan/blame/db9ceb6fa5a5f752b9be0d05ff21b64c2b579ce6/modules/metastore/src/Reference/Referencer.php#L191C7-L191C7