DKAN-4291 add mysql empty row removal option - Githubissues

GetDKAN / dkan

DKAN Open Data Portal

https://dkan.readthedocs.io/en/latest/index.html

GNU General Public License v2.0

374 stars 172 forks source link

DKAN-4291 add mysql empty row removal option #4292

Closed swirtSJW closed 1 month ago

swirtSJW commented 2 months ago

Fixes #4291

Describe your changes

adds a settings page for the datastore_mysql_importer to allow for automatic removal of empty rows after import.
Adds two tests, one for the removal option enabled and one for it disabled.

QA Steps

[ ] Login as admin
[ ] Visit /admin/dkan/datastore/mysql_import
[ ] Validate wording and that changes to the one setting, are properly saved.
[ ] Validate the menu item placement for the settings page
in terminal run ddev dkan-phpunit --group datastore_mysql_import
[ ] validate that tests pass.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

[ ] I have updated or added tests to cover my code
[ ] I have updated or added documentation

janette commented 2 months ago

Thanks for working on this @swirtSJW please include tests for the new code.

dmundra commented 2 months ago

Thanks for working on this @swirtSJW please include tests for the new code.

@swirtSJW check out the tests modules/datastore/modules/datastore_mysql_import/tests/src/Kernel/Service/MysqlImportTest.php in like https://github.com/GetDKAN/dkan/pull/4293/files