#4273: Datastore MySQL Import handles empty file incorrect (with a test) - Githubissues

GetDKAN / dkan

DKAN Open Data Portal

https://dkan.readthedocs.io/en/latest/index.html

GNU General Public License v2.0

374 stars 172 forks source link

#4273: Datastore MySQL Import handles empty file incorrect (with a test) #4293

Closed dmundra closed 2 months ago

dmundra commented 2 months ago

Fixes #4273

Describe your changes

Adds a test to the solution from #4274 (thank you @stefan-korn)

QA Steps

Upload an empty CSV file to a distribution
enable the datastore_mysql_import submodule
Start the import to the datastore (via cron)
Run cron again.
Cron should not fail with an error and instead you should see an import error on the datastore 'error (Can't get size from file ...'

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

[x] I have updated or added tests to cover my code
[ ] I have updated or added documentation