Stop the make file inception

GetDKAN / dkan

DKAN Open Data Portal

https://dkan.readthedocs.io/en/latest/index.html

GNU General Public License v2.0

366 stars 170 forks source link

Stop the make file inception #520

Closed frankcarey closed 7 years ago

frankcarey commented 9 years ago

There are way too many make files that are bing used to create dkan. Worse is that the dkan make file include sub makefiles, which can in turn include sub make files.

DKAN core (drupal-org.make)
  └ dkan_dataset.make
    └ leaflet_widget.make
    └ recline.make
  └ dkan_datastore.make
  └ panopoly_widgets.make
  └ panopoly_images.make

Similar issue with data_starter

TODO

Related Issues / PR

[ ] Move dkan_dataset.make into dkan.make https://github.com/NuCivic/dkan/pull/511

acouch commented 9 years ago

Would there be a better way to do handle this without losing the ability for dkan_dataset and recline to be standalone modules? Otherwise the items from the make file from recline for example would need to be updated in two places.

acouch commented 9 years ago

We talked and agreed on @frankcarey 's plan.

janette commented 7 years ago

Several modules were consolidated into core and the make file simplified https://github.com/NuCivic/dkan/pull/1387