search

GetDKAN / dkan

DKAN Open Data Portal
https://dkan.readthedocs.io/en/latest/index.html
GNU General Public License v2.0
373 stars 171 forks source link

CSS regions used for tests and theming should be cleaned up #810

Closed frankcarey closed 7 years ago

frankcarey commented 8 years ago

Right now, there are a bunch of CSS regions used for testing, but many of them end up using the same css identifiers (".content") is a popular one for instance...

If we're going to use CSS identifiers for testing, the DKAN team should consider implementing consistent classes/ids for things like a "user" page, or a "group" page, etc. While it would be good for testing for them to be more specific and semantic, it would also be more semantic and perhaps cut down on the styling complexity. It would also be wise to set some standards for theming (don't use the built in views and panels classes for instance)

CSS regions used in behat are at: https://github.com/NuCivic/dkan/blob/7.x-1.x/test/behat.yml#L51

kimwdavidson commented 7 years ago

No longer an issue. Closing. Thanks!