GetDKAN / dkan

DKAN Open Data Portal
https://dkan.readthedocs.io/en/latest/index.html
GNU General Public License v2.0
372 stars 172 forks source link

Provide icons for all default resource formats #982

Closed sheldonrampton closed 6 years ago

sheldonrampton commented 8 years ago

CIVIC-3211

Description

When viewing lists of datasets, the little icons reflecting data resource format are correctly displayed, e.g., rest for REST data and csv for CSV data. However, when viewing an individual dataset, the icons for REST data are not correct, e.g. a generic "data" icon displays.

This issue has been documented for DKAN 7.x-1.11.

Steps to Reproduce

Go to a test dataset named "Solid Waste Facilities-Municipal" that I have set up on a fresh install of DKAN 7.x-1.11.

http://dev-dkan-111.getnucivic.com/dataset/solid-waste-facilities-municipal

The dataset contains three resources:

However, the icons which you see on the dataset page are the same for both "Web Services" and "Download Data":

solid_waste_facilities-municipal___test

In other words, the icons for Download Data and Data Table are correct, but having the Web Services item also use the data icon is not correct. It should have a different icon specific to REST data.

You can view the same dataset within a search listing page by searching for the word "solid." If you do so, you will note that each listed data resource has a different name, specific to its format.

Acceptance Criteria

NCS-12

janette commented 8 years ago

the icons rely on the user filling in the 'format' field correctly

screenshot_3_11_16__10_32_am

acouch commented 8 years ago

I don't think I'd qualify this as a bug but a feature request. "Data" is the default. We don't have a mechanism yet for discovery of some file types.

This issue and the linked PRs add a better mechanism for file type discovery that includes many more types and further limits the use of the generic "data": https://github.com/NuCivic/dkan/issues/739

dafeder commented 8 years ago

Also, for better or worse we use an actual icon image in the dataset display, where we use text in the dataset list. We might want to try to do something in the case of default/data dispaly that would display the actual format name in a way that mimics the icon format.

acouch commented 6 years ago

Closing this ticket as it has not been updated recently and is not on our near-term roadmap. Please re-open if you would like to discuss further or are actively working on it.