Submit PR on react-jsonschema-form repo for accessibility issues

GetDKAN / dkan2

Deprecated: please use the 2.x branch of the dkan repo

https://github.com/GetDKAN/dkan

GNU General Public License v2.0

18 stars 16 forks source link

Submit PR on react-jsonschema-form repo for accessibility issues #324

Closed janette closed 4 years ago

janette commented 4 years ago

https://github.com/rjsf-team/react-jsonschema-form

form field should be labelled in some way. Use the label element (either with a "for" attribute or wrapped around the form field), or "title", "aria-label" or "aria-labelledby" attributes as appropriate.

janette commented 4 years ago

Upgrading to the v2.0.0-alpha.2 release fixes most of the text input fields, now only remaining issues are with the multiple value text fields, 'add item' and 'weight' buttons

508

dharizza commented 4 years ago

This issue has multiple ways of fixing, so I'm listing here the PRs

PR against rjsf is here https://github.com/rjsf-team/react-jsonschema-form/pull/1714
PR for updating dkan2 schema is here https://github.com/GetDKAN/dkan2/pull/394
PR for fixing the drush dkan-metadata-form:sync command is here https://github.com/GetDKAN/dkan2/pull/392

janette commented 4 years ago

Merged the PRs on dkan2, just waiting for the PR on rjsf repo to be merged