Client upgrade steps missing

[janette]

Description

The config/overrides.make and config/custom.make files were not run on the 1.14 upgrades, need to run ahoy build remake to get those items into the build.

• perhaps only need ahoy custom post-build on an upgrade...?

[dafeder]

@janette I think you have a better sense of what needs to happen here - want to create a PR for this and I'll review?

[janette]

example output ga_gbpw https://jenkins.nuamsdev.com/view/Upgrades/job/Data%20-%20Create%20Site%20Point%20Release%20PRs/378/console

Seems like everything is in place for this to happen:

1. https://github.com/NuCivic/jenkins_release_n_update_builds/blob/master/upgrade-sites.sh
   • build update is called

     40 ahoy build update $tag
     41 ahoy build config

2. https://github.com/GetDKAN/dkan_starter/blob/master/.ahoy/site/build.ahoy.yml
   • build update calls build update-custom

     update:
     usage: Updates site USE THIS FOR ALL SITE UPDATES.
     cmd: |
     ARGS="{{args}}"
     if [[ -z "$ARGS" ]]; then
     echo "Please provide a Data Starter release (tag) as an argument. Exiting"
     exit 0
     fi
     ahoy build update-dkan-starter "$ARGS"
     ahoy build update-custom

• build update-custom calls build custom, build overrides, build config

  update-custom:
  hidde: true
  usage: Runs all the custom build steps.
  cmd: |
    ahoy build custom
    ahoy build custom-libs
    ahoy build overrides
    ahoy build config
    if [ "$(ahoy custom | grep post-build)" != '' ]
    then
      ahoy custom post-build
    fi

perhaps ahoy build update-custom is being skipped for some reason

[erogray]

No longer relevant