search

GetDotaStats / GetDotaLobby

10 stars 2 forks source link

LXUpdater not updating (probably caused by decimal format for local language) #6

Closed chocolateftw closed 9 years ago

chocolateftw commented 9 years ago

I am using Windows 7 64bit with the language set to german.

If I try to update I get this screen: snip

The file %APPDATA%\version.txt contains the text: 0,33 Notice the comma which is the decimal mark in german. The client seems to convert this text to 33 or 033. (on reading the file) Changing the text in %APPDATA%\version.txt to 0.33 (with a point) fixes the issue. The LXUpdater reads and show the client version correctly and starts updating.

The problem seems to be at the moment when the LXUpdater saves the version number 0.33 to the %APPDATA%\version.txt Maybe Visual Basic saves numbers using the decimal mark for the local language.

bmddota commented 9 years ago

chocolateftw, thanks for the report. We noticed this issue as well and updated the LXUpdater.vbs to handle it. Unfortunately, the updater provides no udpater for itself, so you'll need to download the fixed version at https://github.com/GetDotaStats/GetDotaLobby/raw/master/LXUpdater.zip .

Additionally, you should delete %APPDATA%\version.txt before running the new version as it will likely still goof up. Apologies for the issue.

chocolateftw commented 9 years ago

Thank you for your quick response! Edit: The bug seems to still exist. (Even though I deleted the version.txt and redownloaded the updater) Edit2: Clarification. It will update once, but then again has the version number with a comma in the version.txt and reads that number wrong when i rerun the updater.

chocolateftw commented 9 years ago

Fixed by http://git.io/vefFX