GetDotaStats / stat-collection

Library for setting up stat collection for dota2 mods
http://getdotastats.com/
GNU General Public License v2.0
11 stars 8 forks source link

[SCHEMA] Attack On Hero 2 #118

Open pr0crustes opened 5 years ago

pr0crustes commented 5 years ago

Console log: https://gist.github.com/pr0crustes/ad0bbb6d9d2a9bc6768bbc7a57c89559 Settings.kv: https://gist.github.com/pr0crustes/18dd81a34b9a3f1e67565d88555b2f6d Schema.lua: https://github.com/pr0crustes/AttackOnHero2/blob/master/game/scripts/vscripts/statcollection/schema.lua Addon_game_mode.lua: https://github.com/pr0crustes/AttackOnHero2/blob/master/game/scripts/vscripts/addon_game_mode.lua

I would like to enable this custom Schema. Thanks!

jimmydorry commented 5 years ago

I would suggest renaming your schema fields into something more compact:

Also, you should round game time to the nearest second. You aren't going to get much value out of 10 significant digits (after the decimal point).

I don't remember how Booleans (your anicent_alive variable) are handled. If the schema doesn't work, you will want to convert the Boolean to a number or string: e.g. 'True' or 1 or 'Yes'. You should probably be fine though.

Here's your schema, please review the modified fields.

Feel free to suggest changes!

Schema: https://getdotastats.com/#s2__mod_schema?mid=588

Schema ID: https://getdotastats.com/#s2__my__mods

Your schema ID starts with N7K... not a v1