GetDotaStats / stat-collection

Library for setting up stat collection for dota2 mods
http://getdotastats.com/
GNU General Public License v2.0
11 stars 8 forks source link

[SCHEMA] Battleships #26

Open jimmydorry opened 8 years ago

jimmydorry commented 8 years ago

Type of game play: continuous Rounds: yes Number of rounds: 3 (first ends at 10mins, second at 20mins, 3rd at 30mins)

PROPOSAL1

Developer's current implementation: http://hastebin.com/kuveqigoba.js || http://hastebin.com/tevayemiro.pas

Site counter proposal: http://hastebin.com/zozosonoku.coffee

PROPOSAL2

Developer's current implementation: http://hastebin.com/tepolijoha.lua http://hastebin.com/inajulonow.coffee http://hastebin.com/onaminutes.js || http://hastebin.com/itiludasop.lua

o0oradaro0o commented 8 years ago

Here's what i got: i cant really easily do the kill breakdown by ability

http://hastebin.com/tepolijoha.lua

will it do?

jimmydorry commented 8 years ago

Ready for our Grand Lua Architect @SinZ163 to review.

EDIT SinZ: Lua*

SinZ163 commented 8 years ago
local roundData={
            winnerData,
            gameData,
            playerData,
            roundsLeft,
            }
    winners = roundData.winnerData

winners is now a variable with a value of nil, meaning it explodes when statcollection tries to loop over it

jimmydorry commented 8 years ago

I'm going to be adding another API end point for time lapse data.

Please drop your round support (only report at the end of the game).

I'll be looking to roll out this time lapse view this weekend or early next week.

This timelapse view should offer the build order you are looking for, as well as removing that whole rounding factor that reporting per round would give.

The current round implementation makes the DB grow exponentially, and isn't very efficient due to it storing lots of redundant data that won't be interesting to view per round.

jimmydorry commented 8 years ago

Edited comment to fix errors.

jimmydorry commented 8 years ago

The library was significantly updated recently. Try again using the updated version. It should be more streamlined and easier to implement now. Open this when you are ready to try again.

jimmydorry commented 8 years ago

Final schema

http://hastebin.com/xizuratese.lua