search

GetDotaStats / stat-collection

Library for setting up stat collection for dota2 mods
http://getdotastats.com/
GNU General Public License v2.0
11 stars 8 forks source link

Needs a TEST_SCHEMA parameter #34

Closed jimmydorry closed 8 years ago

jimmydorry commented 8 years ago

People that install this with mods that don't support heroes (etc.), will get errors in their console... now that we print the schema result to console, which obviously will attempt to assemble the data.

e.g. "on schema.lua line 122, GetSelectedHeroName a nil value"

MNoya commented 8 years ago

I think the GetSelectedHeroName error was just me failing to add PlayerResource to it, it's fixed in the test branch so not sure how valid is this now

jimmydorry commented 8 years ago

Awesome.

Do you think it would be easier to have a generic enough schema that always works, or another setting that allows the basic integration out of the box regardless of schema, and makes it clear they need to edit the schema?

MNoya commented 8 years ago

I believe the first one is better, but now with the new utilities.lua file we should just fill that in with anything that the users might need as long as it's not mod-specific (such as fetching a .damage_done value on the hero handles or that sort of stuff)

jimmydorry commented 8 years ago

I should look at the test branch. Sounds good.

MNoya commented 8 years ago

Yeah the only reason I haven't merged the test branch yet is because I'm waiting confirmation for the item-string length, but it might be good enough to just merge it already so people don't need to go back and adjust the changes again

At least we got @ynohtna92 and @fcalife on the IRC to test now