[SCHEMA] Dota IMBA

[fcalife]

Console log

settings.kv (I set "testing" to false only after finishing the test)

schema.lua

addon_game_mode.lua

[jimmydorry]

Looks good.

I would suggest the following, before any admin approves it:

• remove the roshan counter. I doubt you balance on it, and it doesn't seem useful as a total for both teams. If you want it, you should probably track it per team and attach it to players at the end
• make the team value a string. I assume radiant and dire
• drop connection status. You don't appear to have any custom status states defined, and having it as an integer is not useful
• check whether your item names have _ in them. If so concat with a , or - instead. You will want to cap your string length to 100 characters. I was meant to fix that this weekend, but ended up being otherwise pre-occupied

Finally, we are looking for the schema dump part of the console log. Easiest way for you to help us, is by giving the entire console log of a single game. I believe the schema dump part is near the start of the game, when running with the testing setting enabled.

Good work so far.

[jimmydorry]

On second look, your schema looks like the old format. Make sure you are using the latest copy of the library. You need to manually merge your schema into the new one.

[fcalife]

Hi Jimmy!

Updated the schema, seems like the only changes were to the customSchema:init() function (including the initial dump). Also made the changes you suggested.

I couldn't get the dump to print at the start of the game, for whatever reason, so I just used a test command to print the dump at the end of the game. Here's the console log.

Thanks! :)

[jimmydorry]

Game length should be in seconds as we can't aggregate decimals.

All of your field names should be 3 letters max. Just have a comment next to each so we can label them correctly on our end.

One of the admins will put a schema up for you when you do that.

Looks good otherwise.

[fcalife]

Thanks Jimmy!

Made the changes, new file is here.

Thank you!

[jimmydorry]

Approved, log into the site and check your Mod Section:

http://getdotastats.com/#s2__my__mods

The final two changes I would make in your schema:

• Return a string for the team names ("Radiant", "Dire")
• Steal PMP's version flag

https://github.com/MNoya/PMP/blob/master/game/dota_addons/pmp/scripts/vscripts/statcollection/schema.lua#L6

https://github.com/MNoya/PMP/blob/795112fbd19dd7450845e79749d028cf6abe0b42/game/dota_addons/pmp/scripts/vscripts/pmp.lua#L1252

https://github.com/MNoya/PMP/blob/795112fbd19dd7450845e79749d028cf6abe0b42/game/dota_addons/pmp/scripts/vscripts/pmp.lua#L3

Close this issue when you are live.

[fcalife]

Made the changes and went live just now. Huzzah! :)

[jimmydorry]

CreateHTTPRequest() may be blocked for dedis.

Email sent to Valve to see if that is the case. http://i.imgur.com/na7PHwJ.png

[MNoya]

Great news!

[jimmydorry]

Awesome!

[jimmydorry]

We did it!

http://store.steampowered.com/news/18983/

"Custom Games: Fixed a bug that prevented CreateHTTPRequest from working on dedicated servers."

[jimmydorry]

Your Winning Team game value is sometimes wrong (might just be for 10v10).

http://getdotastats.com/#s2__match?id=1174823

[fcalife]

Updated to v2, added a new value to the schema

[jimmydorry]

Which value? We need to know what it is, so we can start recording it.

[fcalife]

Here: https://github.com/fcalife/dota_imba/blob/developer/scripts/vscripts/statcollection/schema.lua#L58

[SinZ163]

uhh whats the point of that new value, if its literally identical to your winning team value which you are sending?

[jimmydorry]

Haha, thought you said you were doing something special. If you want, we can reset stats by giving you a new schemaID. You could then use your new team names for this event.

[fcalife]

Eh, initially the teams and kings were randomized, after some point in development it became a fixed thing and I never mentally updated the fact it made the new schema variable useless.

Just disregard this, lol.

[jimmydorry]

Let us know if you want a new schemaID, so your stats are reset.

[fcalife]

Please - unless we're getting those data filtering by map options any soon, then it won't be needed! :D

Thanks!

[fcalife]

Removed useless game parameter from schema

Jimmy, if you could implement a new schemID to track games from this point on, that'd be great!

Thank you!

[jimmydorry]

Refresh your mod list. Your new schema is v3

[jimmydorry]

Yo, it doesn't look like you are reporting any stats now! Please re-check your schemaID, and make sure you are using all of the required fields. Try a test game to see what error you are reporting!

[jimmydorry]

Check your PRs. I upgraded you to v3, and even fixed your stats for you!

To get your stats working again, all you needed to do was update your schemaID!

[EarthSalamander42]

Hi there! I'm fixing the actual schema, here's the list: schema.lua: https://hastebin.com/ronaxinonu.lua utilities.lua: https://hastebin.com/awegazequl.lua settings.kv: https://hastebin.com/nofiwopefo.scala I've checked eevrything runs well!

[EarthSalamander42]

little update, we don't need more stats for now! schema.lua: https://hastebin.com/eveduparuk.lua utilities.lua: https://hastebin.com/siwugupote.lua

[jimmydorry]

You don't want Winning Hero in the players array. Put the winning hero into the game array, so you can see it per game... instead of per player.

Also, re-add the team name to the player array, and perhaps add winning team to the game array.

[EarthSalamander42]

schema.lua: https://hastebin.com/silaxedawe.lua utilities.lua: https://hastebin.com/axirafafij.lua

[jimmydorry]

game.wh = GetWinningHeroName(playerID) is now in the game array, but you won't be passing it a playerID, and looking what that function does, if you call it without a playerID, it should only give you an empty value.

You needed to change the function to give you something useful at a game level. I was assuming you would do an MVP of the match or something.

Either way, I'll approve the schema, as you at least have something that should work without erroring or giving non-informative data.

[jimmydorry]

Here's your schema, please review the fields to make sure I didn't make a mistake.

Feel free to suggest changes!

Schema: https://getdotastats.com/#s2__mod_schema?mid=74

Schema ID: https://getdotastats.com/#s2__my__mods

Your schema ID starts with C6... not a v5

[EarthSalamander42]

Thanks! updating imba tomorrow!

[EarthSalamander42]

https://getdotastats.com/#s2__mod_cgv?id=74 Still having no stats, i don't understand why...

[jimmydorry]

Check your console log in the developer tools. Most likely reason is not sending all of the values defined in the schema, and the most likely culprit is that game value you moved from player values without reworking to not rely on iterating through the players.

https://getdotastats.com/#s2__mod_schema?mid=74

Run a game in dev tools and try the test functions test_schema and test_end_game that were defined in the schema file.