loading time as a flag

[jimmydorry]

Do we want to try harvesting how long it takes games to start?

[jimmydorry]

Thoughts? @MNoya

With enough data, we could probably reap some sweet leddit karma too.

[MNoya]

For each player, or for the game in general?

Right now the problem relies on using the CUSTOM_GAME_SETUP state to init the library (which is after everyone already loaded already), because WAIT_FOR_PLAYERS_TO_LOAD doesn't trigger on the tools, but we can just replicate an :OnHostLoaded() function to do this.

[jimmydorry]

Game in general. The total loading time is determined by the slowest connection.

At the very least, we should be able to determine how much longer the slowest person took from the host. If we can figure out the hosts loading time, it could be a very legit stat.

[MNoya]

Host loading time is impossible, the game only really starts running code when the host has loaded.

Slowest person is doable, just need to take the time between :OnFirstPlayerLoaded() and CUSTOM_GAME_SETUP. Not sure how it works on dedis though

[jimmydorry]

I was conflating dedis there. The dedi could probably start timing before the lobby host joins (in the case of another player joining first), where as the self hosted can't.

Do you think this stat is interesting enough to bother recording?

[MNoya]

Not really, same as the non-started lobbies data, it was relevant during alpha but now it's not so interesting

[jimmydorry]

Except this is a metric somewhat under the control of the modder, and we will be able to tell when valve makes a big change.

At the very least, i have the concept of an infographic coming together, and load times might be a nice throw away stat.

Up to u if you think it's worth it.

[SinZ163]

Measuring load time would still be useful, as games like Naval warfare take much longer to load than games like predator

[MNoya]

Fair enough, lets do it

[MNoya]

Done in 7b4fe0b0d96d1a9998dff339e7c9cdb10ecbe9a3

[jimmydorry]

I need to whack in the version specific logic that will not require numPlayers for schemaVersion >= 3 as defined in https://github.com/GetDotaStats/site/issues/206

[jimmydorry]

Done, but not pushed live. Will try to remember to push it when I get home.

[jimmydorry]

Done