search

GetDotaStats / stat-collection

Library for setting up stat collection for dota2 mods
http://getdotastats.com/
GNU General Public License v2.0
11 stars 8 forks source link

[SCHEMA] 6.85 Dota Global Skillshots #46

Closed tianrenli92 closed 8 years ago

tianrenli92 commented 8 years ago

http://pastebin.ca/3219281 http://pastebin.ca/3219282 http://pastebin.ca/3219283 http://pastebin.ca/3219285

jimmydorry commented 8 years ago

You will want to lower that MIN_PLAYERS in your settings.kv to 1. When you start getting data, you can raise it to something more reasonable like 4 or 6.

game.len should be clamped to an integer, like math.floor(GameRules:GetGameTime())

Looks good otherwise.

jimmydorry commented 8 years ago

Check your private mod list for your schemaID http://getdotastats.com/#s2__my__mods

tianrenli92 commented 8 years ago

Thank you!

jimmydorry commented 8 years ago

You should lower your MIN_PLAYERS to like 4. You are missing out on a lot of data, lol.

Also, please upgrade to v3 of the library as per the recent email. If you want, I can make a PR.

tianrenli92 commented 8 years ago

thanks for your reminds! min_player is intended as 10 for better watching balance, since there's not a player amount filter on website. i need to review some courses for the final exam recent weeks and will update the v3 no later than the end of nov.

best, tim

Sent from Samsung Mobile

-------- Original message --------
From: jimmydorry notifications@github.com
Date:11/10/2015 11:30 PM (GMT-06:00)
To: GetDotaStats/stat-collection stat-collection@noreply.github.com
Cc: litianren001 406161668@qq.com
Subject: Re: [stat-collection] [SCHEMA] 6.85 Dota Global Skillshots (#46)
You should lower your MIN_PLAYERS to like 4. You are missing out on a lot of data, lol. Also, please upgrade to v3 of the library as per the recent email. If you want, I can make a PR. — Reply to this email directly or view it on GitHub.
jimmydorry commented 8 years ago

Problem upgrade. Schema stopped working. Discussion happening here https://github.com/litianren001/ags_685/pull/2

jimmydorry commented 8 years ago

New schema up at https://github.com/GetDotaStats/stat-collection/issues/63