[SCHEMA] Epic Boss Fight

PlexusDuMenton commented 8 years ago

Console : http://pastebin.com/PPnjN806 setting.kv : http://pastebin.com/47iHnUif shema.lua : http://pastebin.com/cV32BMKb addon_game_mode.lua : http://pastebin.com/yiHUDh2R

SinZ163 commented 8 years ago

variable names on the schema probably should be shorter to preserve bandwidth
for non round-based gamemodes you don't need to send game duration, as stat-collection does that anyway.
you never want to send connection state, as stat-collection does that anyway.

Since your gamemode is a round based thing, might be an idea to use the round API, but stuffs been changing since its conception.

jimmydorry commented 8 years ago

Nuke your lib folder and remove the references to it in your addon_game_mode.lua... like require('lib.statcollection') .
HAS_ROUNDS should be false in your settings.kv. Your game does not have discrete rounds, the data would lose a lot of meaning if it was split into rounds (and there would be way too much of it! Too much for now, that is.)
Split your item list into six separate variables (i1, i2, i3, etc.). We are trying something new and you get to be our lucky tester. The result will be more meaningful than the concatenated string :)
As @SinZ163 said, reduce your variable names to 2 or 3 characters at most. Put a comment next to each one, so we know what it is.
Drop Player_Connection_State
Player_Team should be a meaningful string. If I recall, the two potential values for EBF would be 'Boss' and 'Players'... right?
Is Player_LH actually useful? You could be doing 1000 times more damage than everyone else, but your team could be taking all the last hits, right?
You should add a game variable for lives used, and lives left (I recall EBF having a concept of lives)

Bonus data that would be nice, but would require some work from you to implement:

You should add a player variable for number of allies saved
The ability level for each skill the player has
Damage dealt (requires quite a bit of work to add this)
Damage evaded (requires quite a bit of work to add this)
Damage tanked (requires quite a bit of work to add this)

PlexusDuMenton commented 8 years ago

well , i've listento you here is the new shema : (addon_game_mode didn't changed except to get rid of the old statscollection lib) http://pastebin.com/E1CzLdCi i've added variable for ammount of ally saved , and for ammount of live left/saved/total but i don't think i can make it for damage dealt/evaded or tanked :( http://pastebin.com/9G7PZeby here is the console

next update should be them

MNoya commented 8 years ago

For the empty items you could just return "" instead of "empty"

PlexusDuMenton commented 8 years ago

ok i'll

jimmydorry commented 8 years ago

Drop T_T, it's already covered by the library
Send -1 if the variable is empty and you don't want it displayed in the graphs, otherwise send NULL if you don't want it recorded (I will need to change a few small things on my end, so I won't record NULL values)

Check your mod section to get your schemaID, and you can also check what is in your schema and what field names we are expecting.

http://getdotastats.com/#s2__my__mods

http://getdotastats.com/#s2__mod_schema?mid=27

jimmydorry commented 8 years ago

Yo, it's been about a week. All you needed to do was drop in your schemaID and check that your schema fields matched your site schema. Is there a problem you need help with? I would make a PR, but you are following the 'best practice', of not exposing your IDs (which is good!).

jimmydorry commented 8 years ago

Your stats haven't been working in about a day. I'll make a PR to your library shortly.

jimmydorry commented 8 years ago

Check your pull requests https://github.com/FrenchDeath/EBF/pull/2

Yahnich commented 7 years ago

Is it possible for me to update the EBF schema because a lot of it is super unnecessary and I'd like to replace some of them with more fitting ones.

PlexusDuMenton commented 7 years ago

I agree with it if you ask :)

2016-12-10 22:17 GMT+01:00 Yahnich notifications@github.com:

Is it possible for me to update the EBF schema because a lot of it is super unnecessary .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GetDotaStats/stat-collection/issues/50#issuecomment-266240797, or mute the thread https://github.com/notifications/unsubscribe-auth/AKE63aoACTOEGRcL6hz-wVFxxQte6XE3ks5rGxbYgaJpZM4Gasjb .

SinZ163 commented 7 years ago

What changes do you have in mind?

Yahnich commented 7 years ago

New Game Values: Game Difficulty: String value.

Player Values: Level: Removed, irrelevant Net Worth: Removed, irrelevant Kills: Removed, irrelevant Deaths: Removed, irrelevant Healing: Possibly changed ot Healing Per Second, but that's not necessary GPM: Removed, irrelevant

Instead I would like: DPS; Damage Per Second: Pretty straightforward TD; Team Damage: would be a percentual value from 0%-100%, this one is only needed if there are plans of ever being able to link 2 player values together to see their winrate (hero + team damage for example); otherwise it's fine.

I've tried just bruteforcing these but then I don't have the neat tiering and instead every single seperate value is shown on the pie chart making it overally useless to get info from it.

jimmydorry commented 7 years ago

Glad it's all working now.

Here's your schema, please review the fields to make sure I didn't make a mistake.

Feel free to suggest changes!

Schema: https://getdotastats.com/#s2__mod_schema?mid=27

Schema ID: https://getdotastats.com/#s2__my__mods

Your schema ID starts with VTH... not a v1

Yahnich commented 7 years ago

I'd like 4 new player values:

Ability1: string (a1 is fine) ability2: string ability3: string ability4: string

to help develop my ability picking system; thanks in advance

jimmydorry commented 7 years ago