V4

[jimmydorry]

• Hopefully fixed the dedicated server crash (only launch Stage 1 when the host has connected)
• Change structure to match what the addons actually look like, now that we require modders to drop files into both the game and content folders
• Update readme, bringing it in-line with site
• Tweaked the panorama JS. I noticed it is meant to be interpreted as strict ("use strict";), but was missing the line terminators
• Updated the schemas (a few are still in the old format)
• Improve formatting and standardisation of whitespace

@SinZ163 @MNoya Happy with this? I would suggest quickly looking over the commits individually below, so you can ignore all the files touched by the formatting and moving. It would be super swell if this was tested before actually hitting the main branch.

@FrenchDeath it would be super swell if you would do the honours, after either or both of the above have had a look. We unfortunately don't have a dedicated server enabled mod to test against.

[jimmydorry]

Do the following need to be globals?

https://github.com/GetDotaStats/stat-collection/blob/v3.1/game/dota_addons/YOUR_ADDON/scripts/vscripts/statcollection/lib/statcollection.lua#L126

https://github.com/GetDotaStats/stat-collection/blob/v3.1/game/dota_addons/YOUR_ADDON/scripts/vscripts/statcollection/lib/statcollection.lua#L421

https://github.com/GetDotaStats/stat-collection/blob/v3.1/game/dota_addons/YOUR_ADDON/scripts/vscripts/statcollection/lib/statcollection.lua#L460

https://github.com/GetDotaStats/stat-collection/blob/v3.1/game/dota_addons/YOUR_ADDON/scripts/vscripts/statcollection/lib/statcollection.lua#L496

[jimmydorry]

Also, all of our for loops may be using the wrong max value... causing a lot more work than is required.

<BMD> why do you use DOTA_MAX_PLAYERS there 
<BMD> that's the 64 one
<BMD> DOTA_MAX_TEAM_PLAYERS is the 24 one

[SinZ163]

1. RIP git blame
2. Globals are never needed.

[jimmydorry]

_Through him everyone who believes is set free from every @SinZ163 , a justification you were not able to obtain under the law of Addon-ing._

I absolve you all, of your @SinZ163

So meme it be.

[PlexusDuMenton]

well , bug is fixed from valve side just got the message (sorry for no replying earlier , i was tired as hell and just went to sleep yesterday)

2015-11-17 12:27 GMT+01:00 jimmydorry notifications@github.com:

Through him everyone who believes is set free from every @SinZ163 https://github.com/SinZ163 , a justification you were not able to obtain under the law of Addon-ing.

I absolve you all, of your @SinZ163 https://github.com/SinZ163

So meme it be.

— Reply to this email directly or view it on GitHub https://github.com/GetDotaStats/stat-collection/pull/61#issuecomment-157342733 .