GetDotaStats / stat-collection

Library for setting up stat collection for dota2 mods
http://getdotastats.com/
GNU General Public License v2.0
11 stars 8 forks source link

DynamicHud_Create lua doesn't compile XML #68

Closed MNoya closed 8 years ago

MNoya commented 8 years ago

We should either distribute the .xml_c and make modders copy it to their game panorama folder, or ask them to do the include process in the xml manifest.

jimmydorry commented 8 years ago

What's happened to cause this?

I believe adding some steps to the guide for include process, would be the most robust... as opposed to magic files.

Which way do you want to take it?

MNoya commented 8 years ago

Just noticed the clientside javascript stuff is never running if the xml wasn't previously compiled (by being in the custom manifest, I already had it so I didn't realize until now when I wanted to use it for another library)

Include process would be the best.

  1. Add
<CustomUIElement type="Hud" layoutfile="file://{resources}/layout/custom_game/statcollection.xml" />

to content panorama/layout/custom_game/custom_ui_manifest.xml or create a new one - example

MNoya commented 8 years ago

After that, this line is no longer necessary: https://github.com/GetDotaStats/stat-collection/blob/master/game/dota_addons/YOUR_ADDON/scripts/vscripts/statcollection/lib/statcollection.lua#L195

jimmydorry commented 8 years ago

Okay