search

GetDotaStats / stat-collection

Library for setting up stat collection for dota2 mods
http://getdotastats.com/
GNU General Public License v2.0
11 stars 8 forks source link

Improve game_state matching for phase trigger #74

Open jimmydorry opened 8 years ago

jimmydorry commented 8 years ago

https://github.com/GetDotaStats/stat-collection/issues/73#issuecomment-192308399

I guess there is a new game_state that breaks things. @MNoya has this been happening in eletd or PMP?

SinZ163 commented 8 years ago

It's not new https://github.com/SteamRE/SteamKit/blob/f6c0578506690d63a2b159340fe19835fe33564c/Resources/Protobufs/dota/dota_gcmessages_common.proto#L544

jimmydorry commented 8 years ago

Why haven't we seen this as far larger problem then? Does it kick the game into that state faster than it used to? I can probably answer my own question tomorrow by looking in the dataset.

jimmydorry commented 8 years ago

Recent related changes here:

https://github.com/GetDotaStats/stat-collection/commit/9c3c5e2af5b66c0afdf2f42ff892af4356a99ba9

https://github.com/GetDotaStats/stat-collection/commit/0e4222d25fcdc67f40fde9ac7721101ce903c425

https://github.com/GetDotaStats/stat-collection/commit/025bfd0ad6fce83131c04504b1325c2a1ef8338b