search

GetDotaStats / stat-collection

Library for setting up stat collection for dota2 mods
http://getdotastats.com/
GNU General Public License v2.0
11 stars 8 forks source link

[SCHEMA] Dota 2 Horde Mode #86

Open Diellan opened 7 years ago

Diellan commented 7 years ago

console log: http://pastebin.com/cicmiJWa schema.lua: http://pastebin.com/JWAMt6YL settings.kv: http://pastebin.com/H9Xv1VL5 addon_game_mode.lua: http://pastebin.com/y9riztjM

jimmydorry commented 7 years ago

Awesome. Just heading home now, will have a look after dinner.

jimmydorry commented 7 years ago

I see you have game.gl = GAME_TIME_ELAPSED in your schema (line 55 of http://pastebin.com/JWAMt6YL), but your console log doesn't show it getting recorded (line 73 of http://pastebin.com/cicmiJWa). You will want to double check this, as none of the data will be recorded if I add that field to the schema and you aren't sending it.

Thinking has changed recently, and we now recommend each inventory_item get its own slot, instead of concatenating them into a single list.

You should use the GetItemSlot function in the shared utilities file (https://github.com/GetDotaStats/stat-collection/blob/master/game/dota_addons/YOUR_ADDON/scripts/vscripts/statcollection/lib/utilities.lua#L54)

An example that may be helpful: https://github.com/LegendsOfDota/LegendsOfDota/blob/master/src/scripts/vscripts/pregame.lua#L333-L341

The rest looks good.

jimmydorry commented 7 years ago

Here's your schema, please review the fields to make sure I didn't make a mistake.

Feel free to suggest changes!

Schema: https://getdotastats.com/#s2__mod_schema?mid=149

Schema ID: https://getdotastats.com/#s2__my__mods

Diellan commented 7 years ago

Thanks! I fixed the game time thing and changed my code to use individual item reporting. Just pushed this up to Valve, so we'll see if it works right

Diellan commented 7 years ago

Yep that worked!

Is there a way to retrieve this data via an API call or something? I'd like to run some analysis on hero combinations and hero+item combinations.

jimmydorry commented 7 years ago

No, I usually just give a dump if someone wants it. If there is specific stuff you want, it's probably worth making a feature request. https://github.com/GetDotaStats/site/issues

Also, let's keep the issue open to keep Dota 2 Horde Mode schema stuff together.

Diellan commented 7 years ago

Alright. I'll want to wait until the schema has been up a week or so anyways to make sure I get good data, but then I'm going to want a full dump so I can do a bunch of different cross-analyses (team compositions, hero compositions, etc). Since the game mode can be played with anything from 1 to 5 players on 2 different maps with 5 different difficulties, any data I see that doesn't factor that in is almost useless.