GetDotaStats / stat-collection

Library for setting up stat collection for dota2 mods
http://getdotastats.com/
GNU General Public License v2.0
11 stars 8 forks source link

[SCHEMA] Open Angel Arena #97

Open Chronophylos opened 7 years ago

Chronophylos commented 7 years ago

Console log: https://hastebin.com/aqazeyusid.txt settings.kv: https://hastebin.com/karizijeci.scala schema.lua: https://hastebin.com/aviceqefaj.lua addon_game_mode.lua: https://hastebin.com/wiwufoqozo.lua

Other files that defines functions we pull stats from:

jimmydorry commented 7 years ago

I don't see gl and wt in your console log. If your schema doesn't work, check that they actually appear in the log.

gl must be an integer. Use math.floor(GAME_TIME_ELAPSED)


Here's your schema, please review the fields to make sure I didn't make a mistake.

Feel free to suggest changes!

Schema: https://getdotastats.com/#s2__mod_schema?mid=156

Schema ID: https://getdotastats.com/#s2__my__mods

Your schema ID starts with XX... not a v1

Chronophylos commented 7 years ago

Thanks! I fixed it: https://hastebin.com/yixucehori.md Can you change Team 1 Caves and Team 2 Caves to Team 1 Cave Cleares and Team 2 Cave Cleares and set their objective to Maximise?

jimmydorry commented 7 years ago

Done. Changing the field display names doesn't change the schema version.

Chronophylos commented 7 years ago

Thank you.

Chronophylos commented 7 years ago

We set up the settings.kv correctly but on getdotastats.com no entries appear, even after the update. Do you know what the problem could be?

jimmydorry commented 7 years ago

No clue. Check your console log, as it will list the error.

The most common causes are:

Chronophylos commented 7 years ago

Can you do some changes in the schema?

jimmydorry commented 7 years ago

Done

Chronophylos commented 7 years ago

Thanks

Haganeko commented 7 years ago

Is it possible to purge the Game/Player Values stats after major updates? I don't know whether this is possible or happens automatically or something, but otherwise it'll be harder to see the balance impacts of changes.

jimmydorry commented 7 years ago

The two options are to wait a week (you need the new data anyway), or to get a new schemaID (request a small change to the schema and automatically get a new schemaID).

Haganeko commented 7 years ago

Ah. So it resets automatically every week. Thank you!

jimmydorry commented 7 years ago

It's a rolling window of up to the last week of stats. Add a new flag to track version to see how much of the data is reported from which version.

jimmydorry commented 7 years ago

Look at what CIA and other mods have done. https://getdotastats.com/#s2__mod_f?id=137

statCollection:setFlags({version = '4.20'})

Chronophylos commented 7 years ago

We are setting such a flag

Chronophylos commented 7 years ago

Also, is there a way to get our stats from your server?

jimmydorry commented 7 years ago

Doesn't look like you are setting a version flag. This is a recent game. https://getdotastats.com/#s2__match?id=23578219

As to getting data. I sometimes do a data dump on request, but the data won't be much use to you raw.

Chronophylos commented 7 years ago

Hm, we're setting the flag in customSchema:init() like in the example

jimmydorry commented 7 years ago

Test in a local game, and see what gets reported. You'll know via console log (it says something like flag successfully set) as well as via the site, if it works. You may have done it all perfectly, but Steam is simply not serving up your update to some clients (i.e. they haven't restarted dota).

Putting it in customSchema:init() may end up being too late. You need to set it after the library is loaded but before the game starts. The best time to do it is during hero selection where mods typically allow players to vote on game options.

LoD Redux

CIA

Chronophylos commented 7 years ago

Thanks, I'll try putting it somewhere earlier