GetDutchie / brick

An intuitive way to work with persistent data in Dart
https://getdutchie.github.io/brick/#/
361 stars 28 forks source link

bug: SupabaseAdapter is missing the onConflict override #428

Closed devj3ns closed 2 months ago

devj3ns commented 2 months ago

My Customer model has no onConflict specified in the SupabaseSerializable, which results in the following runtime error:

lib/brick/adapters/customer_adapter.g.dart:116:7: Error: The non-abstract class 'CustomerAdapter' is missing implementations for these members:
 - SupabaseAdapter.onConflict

Current behavior: When onConflict is not specified in the SupabaseSerializable, the generator does not override the onConflict field in the OfflineFirstWithSupabaseAdapter.

Expected behavior: The generator overrides the field as follows, when onConflict is not specified:

@override
final onConflict = null;

related: https://github.com/GetDutchie/brick/pull/422

tshedor commented 2 months ago

Fixed and published in #430