search

GetDutchie / datadog_flutter

**This community package has been deprecated in favor of Datadog's official SDK**
https://github.com/DataDog/dd-sdk-flutter
MIT License
24 stars 24 forks source link

pod 'DatadogSDKCrashReporting' is missing as of 1.7.3 #99

Closed dballance closed 2 years ago

dballance commented 2 years ago

95 does not add pod 'DatadogSDKCrashReporting' as a dependency. See: https://github.com/DataDog/dd-sdk-ios/issues/778

This causes a crash during builds:

Swift Compiler Error (Xcode): No such module 'DatadogCrashReporting'
/opt/flutter/.pub-cache/hosted/pub.dartlang.org/datadog_flutter-1.7.3/ios/Classes/SwiftDatadogFlutterPlugin.swift:5:7
tshedor commented 2 years ago

Just when I think all the bugs are resolved. This is fixed in 1.7.3+1 via #100 .

Thanks for filing @dballance . cc @karthik-js @fabricio-sisplan @neelansh-creatorstack

scopendo commented 2 years ago

I'm getting an error with 1.7.3+1 – first time install so haven't had earlier versions.

[!] The 'Pods-Runner' target has transitive dependencies that include statically linked binaries: (DatadogSDKCrashReporting)

If tried pod deintegrate, rm Podfile.lock, pod install --repo-update without any improvement.

scopendo commented 2 years ago

Just tried with version 1.7.2 and had success.

dustin-graham commented 2 years ago

@tshedor I don't think this should be closed. it's broken on the latest build 1.7.3+1.

tshedor commented 2 years ago

@scopendo I was able to successfully run this yesterday. I ensured 1.7.3 was installed and datadog_flutter 0.0.3 was the version in Podfile.lock. Your error, however, indicates that there's something in the building in Xcode. I'll most likely need to do something with s.static_framework or s.vendored_libraries.

I don't have time to reasonably deal with maintenance right now, so I'm rolling back 1.7.3+1 and 1.7.3. 1.7.3+2 is effectively 1.7.2. cc @Dachmian via #92 .

If anyone can help on Xcode compilation, I'd really appreciate it. Otherwise I'm going to re-close this issue Friday afternoon PST.

damir-fell commented 2 years ago

@tshedor We are testing a fix in the mentioned forked repo. If it works we can post a PR here.

tshedor commented 2 years ago

@damir-fell looks like we were on the same track. I'll be merging this in shortly and publishing a pre release.

damir-fell commented 2 years ago

@tshedor Awesome, even better.

tshedor commented 2 years ago

@damir-fell this is available in 2.0.0-beta.1