encode_unsigned_1 - Githubissues

GetFirefly / firefly

An alternative BEAM implementation, designed for WebAssembly

Apache License 2.0

3.61k stars 104 forks source link

encode_unsigned_1 #676

Open mlwilkerson opened 4 years ago

mlwilkerson commented 4 years ago

closes #671

[x] test boundary case for smallest bigint
[x] add proptest for non-integer
[x] add proptest for negative integer
[x] fix bug with dropping middle zeros
[x] fix bug with BigInt with trailing zeros
[x] migrate unit tests to integration tests

mlwilkerson commented 4 years ago

I've migrated the tests to the integration testing pattern. Should the unit tests be removed entirely? That'd result in a loss of some coverage from the proptests, at least.

Also, when doing these as integration tests, all of the ones that use big integer inputs are failing with badarg when I wouldn't expect them to--and they don't fail in the unit tests. This suggests that something higher up in the stack is balking at these big integers, but I haven't investigated that.

bcardarella commented 3 years ago

FYI I'll ask about this PR in today's standup