feat(components-native): Add testID prop to components-native Icon

taylorvnoj commented 4 months ago

Motivations

Allow a pass-through of a testID prop

Changes

Added

new testID prop on components-native Icon
tests for: using the testID prop & the situation where someone has used name as data-testid instead.

Why I did what I did

Keeping `testID || name`

In components-native where we have suffix, prefix or components like Button where we have icon as a prop:

interface ButtonFoundationProps {
 ...
  readonly icon?: IconNames;

We're bringing in IconNames and teams are using that to test that an Icon is being used in these components as prefixes, etc. So, only having testID here is not only more of a breaking change than I originally thought. I don't think we should expect consumers of Button to put a testID on a nested Icon that's being rendered as a prop.

Testing

Nothing fails in external mobile repo: https://github.com/GetJobber/jobber-mobile/pull/9365

In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

cloudflare-workers-and-pages[bot] commented 4 months ago

Deploying atlantis with Cloudflare Pages

Latest commit:	`ea79a28`
Status:	✅ Deploy successful!
Preview URL:	https://99ea1a70.atlantis.pages.dev
Branch Preview URL:	https://job-97720-job-97888-add-test.atlantis.pages.dev

View logs

github-actions[bot] commented 4 months ago

Published Pre-release for ea79a2864bbe8912d3b9a44f90bfb86286bfe8a2 with versions:

  - @jobber/components-native@0.67.7-JOB-97720.28+ea79a286

To install the new version(s) for Mobile run:

npm install @jobber/components-native@0.67.7-JOB-97720.28+ea79a286

GetJobber / atlantis