search

GetJobber / atlantis

🔱 Atlantis
https://atlantis.getjobber.com
MIT License
27 stars 30 forks source link

fix(components): use semantic values in ComboBox and Chip #1944

Closed chris-at-jobber closed 3 months ago

chris-at-jobber commented 4 months ago

Motivations

ComboBox and Chip / ChipDismissible use some non-semantic values which do not translate well into dark mode.

The ComboBox search also uses browser-default placeholder color, which is not an Atlantis color and does not respond to dark mode.

In addition, our examples story for Chip also uses base values, giving consumers an anti-pattern as an example.

image image

Changes

Added

Changed

Fixed

Security

Testing

Changes can be tested via Pre-release

In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

cloudflare-workers-and-pages[bot] commented 4 months ago

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4b7baf3
Status: âœ…  Deploy successful!
Preview URL: https://31184c12.atlantis.pages.dev
Branch Preview URL: https://clean-up-styling-in-combobox.atlantis.pages.dev

View logs

github-actions[bot] commented 4 months ago

Published Pre-release for 891a387b60efe9c3a4d64d00050debccdb4854fd with versions:

  - @jobber/components@5.16.2-clean-up-s.1+891a387b

To install the new version(s) for Web run:

npm install @jobber/components@5.16.2-clean-up-s.1+891a387b
JeffMarvin commented 3 months ago

@chris-at-jobber is away for another week. Changes look good and I support @nad182's review. MERGING IT!