fix(components): Loosen React Dependency Version Requirement

GetJobber / atlantis

🔱 Atlantis

https://atlantis.getjobber.com

MIT License

25 stars 30 forks source link

fix(components): Loosen React Dependency Version Requirement #1952

Closed ZakaryH closed 2 months ago

ZakaryH commented 2 months ago

Motivations

I'm having trouble installing latest master in Jobber. it's yelling about React version dependency resolution. I suspect it's because we have "react": "18.2.0" which is quite specific and when it doesn't get exactly that, it can't resolve.

Changes

"18.2.0" -> "^18.2.0"

Added

Changed

Deprecated

Removed

Fixed

Security

Testing

Changes can be tested via Pre-release

In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying atlantis with Cloudflare Pages

Latest commit:	`ac9e7fe`
Status:	✅ Deploy successful!
Preview URL:	https://22c688f0.atlantis.pages.dev
Branch Preview URL:	https://job-81443-loosen-react-depen.atlantis.pages.dev

View logs

ZakaryH commented 2 months ago

noticing a few things that aren't quite right. I'll double check that they weren't caused by this, and if not probably make a ticket or two for 'em

after clicking to open the Mobile/Basic ContentOverlay I get an error

InputNumber/Mobile/Basic can't type or clear it InputSearch/Mobile/Basic can't clear

ZakaryH commented 2 months ago

this ain't right. however it's totally unrelated to this change. seems like our flex style is causing the first child to be full width despite the fact that it's a span and should be inline block

github-actions[bot] commented 2 months ago

Published Pre-release for ac9e7fe52cf0caeef1399515ce2183a91393d0ee with versions:

  - @jobber/components-native@0.69.1-JOB-81443.4+ac9e7fe5

To install the new version(s) for Mobile run:

npm install @jobber/components-native@0.69.1-JOB-81443.4+ac9e7fe5

ZakaryH commented 2 months ago

prerelease is failing because package.json changes are ignored and so it's breaking on the thing that this PR is trying to fix

we'll need to make a commit in README or some src tracked file for it to trigger and pick up the change

MichaelParadis commented 2 months ago

@ZakaryH RE: the content overlay. That mobile version does mention that web might be different (it looks like it isn't displaying now that we don't show the Docs page in the new storybook version because it isn't rendering on the canvas https://github.com/GetJobber/atlantis/blob/JOB-81443/loosen-react-dependency-req/docs/components/ContentOverlay/Mobile.stories.tsx