GetJobber / atlantis

🔱 Atlantis
https://atlantis.getjobber.com
MIT License
25 stars 30 forks source link

fix(components-native): Add support for italics in Atlantis `Typography` component (JOB-101940) #1977

Closed sabidhasan closed 1 month ago

sabidhasan commented 1 month ago

Motivations

We discovered that the Atlantis' Typography native component was missing italics support (when we set the fontStyle prop to italics, it was still rendering regular text). The Web component supports this prop. This functionality will be required for the Markdown component that we are planning on introducing to support italicized text.

To this end, this PR to packages/components-native introduces support for italic text styling in the Typography component.

Before

Italic

image

Regular

image

After

Italic

image

Regular

image

Changes

Fixed

QA

You can test this in Storybook to ensure the style is applied. Or alternatively, install into the Jobber Mobile app locally and test that way for more higher fidelity testing.

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e51c7d
Status: âœ…  Deploy successful!
Preview URL: https://ac2ff7ac.atlantis.pages.dev
Branch Preview URL: https://job-101940-add-support-for-i.atlantis.pages.dev

View logs

github-actions[bot] commented 1 month ago

Published Pre-release for 9be6e610f02772de62d13a01a945a74f89b0c184 with versions:

  - @jobber/components-native@0.66.1-JOB-101940.4+9be6e610

To install the new version(s) for Mobile run:

npm install @jobber/components-native@0.66.1-JOB-101940.4+9be6e610
suark commented 1 month ago

We need to add the device font files to support italic fonts. That work is started in the Jobber Mobile side of things in this PR: https://github.com/GetJobber/jobber-mobile/pull/9490 and I'm going to make a PR to this branch, with a few small changes needed to support those new fonts.

suark commented 1 month ago

https://github.com/GetJobber/jobber-mobile/pull/9490 Was merged to prepare Jobber Mobile for when this Atlantis change supports Italics.

When this Atlantis branch update is combined with mobile, it can now go from this:

Screenshot 2024-08-08 at 11 47 35 AM

to this:

Screenshot 2024-08-08 at 3 44 41 AM