Closed sabidhasan closed 1 month ago
Latest commit: |
3e51c7d
|
Status: | ✅ Deploy successful! |
Preview URL: | https://ac2ff7ac.atlantis.pages.dev |
Branch Preview URL: | https://job-101940-add-support-for-i.atlantis.pages.dev |
Published Pre-release for 9be6e610f02772de62d13a01a945a74f89b0c184 with versions:
- @jobber/components-native@0.66.1-JOB-101940.4+9be6e610
To install the new version(s) for Mobile run:
npm install @jobber/components-native@0.66.1-JOB-101940.4+9be6e610
We need to add the device font files to support italic fonts. That work is started in the Jobber Mobile side of things in this PR: https://github.com/GetJobber/jobber-mobile/pull/9490 and I'm going to make a PR to this branch, with a few small changes needed to support those new fonts.
https://github.com/GetJobber/jobber-mobile/pull/9490 Was merged to prepare Jobber Mobile for when this Atlantis change supports Italics.
When this Atlantis branch update is combined with mobile, it can now go from this:
to this:
Motivations
We discovered that the Atlantis' Typography native component was missing italics support (when we set the
fontStyle
prop to italics, it was still rendering regular text). The Web component supports this prop. This functionality will be required for the Markdown component that we are planning on introducing to support italicized text.To this end, this PR to
packages/components-native
introduces support for italic text styling in the Typography component.Before
Italic
Regular
After
Italic
Regular
Changes
Fixed
italic
style to the typography tokens.InternalTypography
function to apply theitalic
style conditionally based on thefontStyle
prop.QA
You can test this in Storybook to ensure the style is applied. Or alternatively, install into the Jobber Mobile app locally and test that way for more higher fidelity testing.