Open taylorvnoj opened 1 month ago
This is a POC to see what an actions menu would involve on FormatFile.
FormatFile
There may be more actions than just delete moving forward on the FormatFile component (ex. download).
delete
download
Instead of adding an onDownload prop which is just another callback, we can open up a menu to allow for endless customizable options in the future.
onDownload
FormatFileMenu
onDelete
actions?.length > 0
compact
base
Changes can be tested via Pre-release
In Atlantis we use Github's built in pull request reviews.
18485f3
View logs
Motivations
This is a POC to see what an actions menu would involve on
FormatFile
.There may be more actions than just
delete
moving forward on theFormatFile
component (ex.download
).Instead of adding an
onDownload
prop which is just another callback, we can open up a menu to allow for endless customizable options in the future.Added
FormatFileMenu
component withinFormatFile
Not done yet/future considerations
onDelete
actions?.length > 0
compact
&base
props are in effectChanges can be tested via Pre-release
In Atlantis we use Github's built in pull request reviews.