GetJobber / atlantis

🔱 Atlantis
https://atlantis.getjobber.com
MIT License
27 stars 30 forks source link

feat(components): allow custom title for Disclosure #1992

Closed demoraesgui closed 2 months ago

demoraesgui commented 2 months ago

Motivations

In this update, I've introduced additional flexibility to the Disclosure component by allowing the use of an ReactNode | ReactNode[] combination as the title. This enhancement provides developers with more options for crafting visually engaging and informative titles, improving the overall user experience and making the component more versatile across different use cases.

Changes

Disclosure component was updated to either fallback to the current behavior if a string is provided as title or render the ReactNode | ReactNode[] as is.

Added

Storybook:

Dependency Updates:

Changed

Disclosure Component:

Testing

Changes can be tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: e408d09
Status: ✅  Deploy successful!
Preview URL: https://4c2c9076.atlantis.pages.dev
Branch Preview URL: https://feat-custom-title-for-disclo.atlantis.pages.dev

View logs

demoraesgui commented 2 months ago

Thanks for the feedback @nad182. Would you mind giving another look?