Closed nad182 closed 2 months ago
@demoraesgui , I assigned you just as an FYI, since you worked on this originally.
Latest commit: |
3ec60f0
|
Status: | ✅ Deploy successful! |
Preview URL: | https://a242a3cd.atlantis.pages.dev |
Branch Preview URL: | https://fix-disclosure-docs-and-exam.atlantis.pages.dev |
Motivations
This PR provides a better documentation and example of the acceptable way to pass
title
to theDisclosure
component in case it's not just a string, but a React ComponentChanges
Added
title
prop in the Storybook Docs.title
in theChanged
span
instead ofh4
, since this component appears inside of<summary
, hence the content should be of "phrasing content" type, which was added to the docs.title
prop to beReactElement
andReactElement[]
instead ofReactNode
andReactNode[]
, since typestring
IS aReactNode
.Deprecated
Removed
Fixed
Security
Testing
Disclosure
component provide a comprehensive explanation of what can be passed as atitle
.CustomTitle
story behaves and looks as expected.Changes can be tested via Pre-release
In Atlantis we use Github's built in pull request reviews.