fix(components): match Glimmer mobile styles to web

chris-at-jobber commented 3 weeks ago

Motivations

Because the Glimmer was using a surface--background token, it was actually quite difficult to parse when used overtop surface--background or other surface-- variants.

In addition, it was inconsistent with the web Glimmer, which uses a neutral value.

Changes

Changed

semantic color tokens to rgb value so the Glimmer works better overlaid across assorted surfaces

Fixed

mobile Glimmer works better across various surface types

Testing

Changes can be tested via Pre-release

In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

cloudflare-workers-and-pages[bot] commented 3 weeks ago

Deploying atlantis with Cloudflare Pages

Latest commit:	`699a0a9`
Status:	✅ Deploy successful!
Preview URL:	https://0f761fbf.atlantis.pages.dev
Branch Preview URL:	https://match-look-and-feel-of-mobil.atlantis.pages.dev

View logs

github-actions[bot] commented 2 weeks ago

Published Pre-release for 699a0a99a6aaacff0c7f7dec547de607ce871d81 with versions:

  - @jobber/components-native@0.71.2-match-look-699a0a9.15+699a0a99

To install the new version(s) for Mobile run:

npm install @jobber/components-native@0.71.2-match-look-699a0a9.15+699a0a99

GetJobber / atlantis

fix(components): match Glimmer mobile styles to web #2004