Open chris-at-jobber opened 2 weeks ago
Latest commit: |
1e268bb
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f34e6117.atlantis.pages.dev |
Branch Preview URL: | https://improve-disclosure-interacti.atlantis.pages.dev |
Published Pre-release for 24773b810352c0dd596448af5773466908fe917f with versions:
- @jobber/components@5.29.1-improve-di-24773b8.2+24773b81
To install the new version(s) for Web run:
npm install @jobber/components@5.29.1-improve-di-24773b8.2+24773b81
Some QA findings: Feature comparison uses disclosures but changes a bunch of the styling which has it's issues with negative margins.
@fagnanm good catch, can make sure to go in and fix that up when we pull this in
Motivations
Improve the appearance of hover and focus states and make them more consistent with other Atlantis elements
https://github.com/user-attachments/assets/8071df53-4fa1-4c70-bdf6-71c7150450e4
Changes
Changed
radius
of small to Disclosure (as it is typically a child component)Fixed
Testing
Test in Storybook and via prerelease
Changes can be tested via Pre-release
In Atlantis we use Github's built in pull request reviews.