GetJobber / atlantis

🔱 Atlantis
https://atlantis.getjobber.com
MIT License
25 stars 30 forks source link

fix(components): update Disclosure focus and hover styling #2009

Open chris-at-jobber opened 2 weeks ago

chris-at-jobber commented 2 weeks ago

Motivations

Improve the appearance of hover and focus states and make them more consistent with other Atlantis elements

https://github.com/user-attachments/assets/8071df53-4fa1-4c70-bdf6-71c7150450e4

Changes

Changed

Fixed

Testing

Test in Storybook and via prerelease

Changes can be tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

cloudflare-workers-and-pages[bot] commented 2 weeks ago

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1e268bb
Status: âœ…  Deploy successful!
Preview URL: https://f34e6117.atlantis.pages.dev
Branch Preview URL: https://improve-disclosure-interacti.atlantis.pages.dev

View logs

github-actions[bot] commented 2 weeks ago

Published Pre-release for 24773b810352c0dd596448af5773466908fe917f with versions:

  - @jobber/components@5.29.1-improve-di-24773b8.2+24773b81

To install the new version(s) for Web run:

npm install @jobber/components@5.29.1-improve-di-24773b8.2+24773b81
fagnanm commented 3 days ago

Some QA findings: Feature comparison uses disclosures but changes a bunch of the styling which has it's issues with negative margins. image image

chris-at-jobber commented 18 hours ago

@fagnanm good catch, can make sure to go in and fix that up when we pull this in