fix(components): Add ref prop to primary and secondary actions on Page component

nateb-jobber commented 2 weeks ago

Motivations

I needed a popover on a button, but the button was a page primary action.

Changes

Added

Changed

added ref to div wrapping primary and secondary action buttons
modified storybook to show example of change
added test to make sure the ref prop is not passed into the button component

Deprecated

Removed

Fixed

Security

Testing

Open Page "With Actions" storybook
Click the primary and secondary actions to see the Popover

Changes can be tested via Pre-release

In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

ZakaryH commented 2 weeks ago

@nateb-jobber looks great!

one little thing about the type casting and then the align-self on the actionGroup should fix the extra spacing between the popover and the buttons on large screens

cloudflare-workers-and-pages[bot] commented 2 weeks ago

Deploying atlantis with Cloudflare Pages

Latest commit:	`46b8136`
Status:	✅ Deploy successful!
Preview URL:	https://d1a11744.atlantis.pages.dev
Branch Preview URL:	https://add-popover-ref-to-page-comp.atlantis.pages.dev

View logs