Closed chris-at-jobber closed 1 month ago
Latest commit: |
06feed3
|
Status: | ✅ Deploy successful! |
Preview URL: | https://5be7159e.atlantis.pages.dev |
Branch Preview URL: | https://add-radius-to-datalist-heade.atlantis.pages.dev |
Is the fact that there is a lot more padding on the right hand side as opposed to the left hand side purposeful? For example here there is more space between the arrows and the border than the H and the border. It looks off to me
@Aiden-Brine yes that's a very fair point! I'll push up a change here
@Aiden-Brine evened out the spacing - also found that fixing this resolved the long-standing issue with right-aligned sortable column headers and their content!
Previously:
@chris-at-jobber Looks great! Thank you for making that change
Motivations
The focus state for DataList headers looked a little unfinished with no radius
Changes
Changed
Fixed
Testing
You can test in Cloudflare or locally by tabbing through the interface and observing the slightly rounded corners.
Changes can be tested via Pre-release
In Atlantis we use Github's built in pull request reviews.