GetJobber / atlantis

🔱 Atlantis
https://atlantis.getjobber.com
MIT License
27 stars 30 forks source link

feat(components): small improvement to focus state of DataList headers #2014

Closed chris-at-jobber closed 1 month ago

chris-at-jobber commented 2 months ago

Motivations

The focus state for DataList headers looked a little unfinished with no radius

Changes

Changed

Fixed

Testing

You can test in Cloudflare or locally by tabbing through the interface and observing the slightly rounded corners.

Changes can be tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 06feed3
Status: âœ…  Deploy successful!
Preview URL: https://5be7159e.atlantis.pages.dev
Branch Preview URL: https://add-radius-to-datalist-heade.atlantis.pages.dev

View logs

Aiden-Brine commented 1 month ago

Is the fact that there is a lot more padding on the right hand side as opposed to the left hand side purposeful? For example here there is more space between the arrows and the border than the H and the border. It looks off to me image

chris-at-jobber commented 1 month ago

@Aiden-Brine yes that's a very fair point! I'll push up a change here

chris-at-jobber commented 1 month ago

@Aiden-Brine evened out the spacing - also found that fixing this resolved the long-standing issue with right-aligned sortable column headers and their content! image image

Previously: image

Aiden-Brine commented 1 month ago

@chris-at-jobber Looks great! Thank you for making that change