GetJobber / atlantis

🔱 Atlantis
https://atlantis.getjobber.com
MIT License
27 stars 30 forks source link

feat(components): Expose variation prop for Chip used in Chips component #2027

Open MichaelParadis opened 2 months ago

MichaelParadis commented 2 months ago

Motivations

During our separate Chip from Chips PR https://github.com/GetJobber/atlantis/pull/1995 we unintentionally changed the default background color of the Chip used in the Chips component, this PR allows the setting of a variation which will allow subtle Chip components which will have a "white" background

Subtle Chips component:

image

Subtle multiselect

image

Subtle dismissable

image

Changes

Added

Changed

Deprecated

Removed

Fixed

Security

Testing

git revert 9a66fd4495033a0cba44254325ae01b8fdae3d61 to allow you to interact with the Chips stories that make use of the new variation prop in Storybook

Changes can be tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a66fd4
Status: âœ…  Deploy successful!
Preview URL: https://dd08b0c1.atlantis.pages.dev
Branch Preview URL: https://mike-add-chip-variation-to-a.atlantis.pages.dev

View logs

github-actions[bot] commented 2 months ago

Published Pre-release for 9a66fd4495033a0cba44254325ae01b8fdae3d61 with versions:

  - @jobber/components@5.29.2-MIKEadd-c-9a66fd4.8+9a66fd44

To install the new version(s) for Web run:

npm install @jobber/components@5.29.2-MIKEadd-c-9a66fd4.8+9a66fd44
chris-at-jobber commented 2 months ago

@MichaelParadis can we change this so that in single or multi-select flows, the selected Chip is the base variant, with un-selected being subtle?

MichaelParadis commented 2 months ago

@chris-at-jobber yes, I am not sure how that wouldn't solve the issue from the initial thread that brought this issue to our attention

chris-at-jobber commented 2 months ago

@MichaelParadis discussed with the impacted team's designer and how we'll proceed is