Open MichaelParadis opened 2 months ago
Latest commit: |
9a66fd4
|
Status: | ✅ Deploy successful! |
Preview URL: | https://dd08b0c1.atlantis.pages.dev |
Branch Preview URL: | https://mike-add-chip-variation-to-a.atlantis.pages.dev |
Published Pre-release for 9a66fd4495033a0cba44254325ae01b8fdae3d61 with versions:
- @jobber/components@5.29.2-MIKEadd-c-9a66fd4.8+9a66fd44
To install the new version(s) for Web run:
npm install @jobber/components@5.29.2-MIKEadd-c-9a66fd4.8+9a66fd44
@MichaelParadis can we change this so that in single or multi-select flows, the selected Chip is the base variant, with un-selected being subtle?
@chris-at-jobber yes, I am not sure how that wouldn't solve the issue from the initial thread that brought this issue to our attention
@MichaelParadis discussed with the impacted team's designer and how we'll proceed is
subtle
as the variant for all unselected Chips in single- and multi-select mode
Motivations
During our separate Chip from Chips PR https://github.com/GetJobber/atlantis/pull/1995 we unintentionally changed the default background color of the
Chip
used in theChips
component, this PR allows the setting of avariation
which will allowsubtle
Chip components which will have a "white" backgroundSubtle Chips component:
Subtle multiselect
Subtle dismissable
Changes
Added
Changed
variation
prop in theChip
component used inChips
Deprecated
Removed
Fixed
Security
Testing
git revert 9a66fd4495033a0cba44254325ae01b8fdae3d61
to allow you to interact with the Chips stories that make use of the new variation prop in StorybookChanges can be tested via Pre-release
In Atlantis we use Github's built in pull request reviews.