search

GetJobber / atlantis

🔱 Atlantis
https://atlantis.getjobber.com
MIT License
25 stars 30 forks source link

refactor(components): Add semantic colors to typography on web [97200] #2030

Closed Aiden-Brine closed 19 hours ago

Aiden-Brine commented 1 week ago

Motivations

It would be desirable for developers to be able to pass any type of semantic color to the typography component

Changes

Various colors added to TextColors.css based on semantic.css and in turn TextColors.css.d.ts was automatically updated. I also added a snapshot test with a semantic colour.

Added

~31~ 44 semantic colors added and a snapshot test

Changed

N/A

Deprecated

N/A

Removed

N/A

Fixed

N/A

Security

N/A

Testing

Open up story book and play around with different semantic text colours

Changes can be tested via Pre-release

In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

cloudflare-workers-and-pages[bot] commented 1 week ago

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: a149cc7
Status: âœ…  Deploy successful!
Preview URL: https://637d5817.atlantis.pages.dev
Branch Preview URL: https://job-97200-typography-semanti.atlantis.pages.dev

View logs

Aiden-Brine commented 1 week ago

@chris-at-jobber I added all of the semantic colours but if there are any that don't make sense for text and you would like removed please let me know

chris-at-jobber commented 1 week ago

Thanks @Aiden-Brine ! I definitely had a first gut reaction of "Hmm I'm not sure anyone needs to use color-focus for their text... So we could definitely start with a more curated list. If we did, something like

Typography

Statuses

Interactions

Workflow

Miscellanea

I think you already have most of these aside from the "workflow" colors captured here, so really it would mainly be removing things like borders and surfaces.