GetJobber / atlantis

🔱 Atlantis
https://atlantis.getjobber.com
MIT License
27 stars 30 forks source link

fix(components): Fix row actions being inaccessible on touch screen devices #2032

Open MichaelParadis opened 1 month ago

MichaelParadis commented 1 month ago

Motivations

In https://github.com/GetJobber/atlantis/pull/2012 there was a concern that uses on a touch screen device that was in a larger breakpoint would lose the ability to select a row action. This PR fixes that by allowing the actions menu to be visible on hover if the user is hovering over the currently selected item and only one item is selected.

Changes

Added

Changed

Deprecated

Removed

Fixed

Security

Testing

Verify the row actions display when on a touch screen device and the option is selected

Device with hover https://github.com/user-attachments/assets/7807bdc8-8169-4c47-a1d5-c6365ff34c43
Device without hover https://github.com/user-attachments/assets/5fe98fd3-9b7b-4611-9789-88ee87f425b1

Changes can be tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a752f9
Status: âœ…  Deploy successful!
Preview URL: https://d3bc8607.atlantis.pages.dev
Branch Preview URL: https://mike-fix-row-actions-hidden.atlantis.pages.dev

View logs