feat(deps): Update storybook to the latest patch version (7.6.20)

nad182 commented 2 months ago

Motivations

The Storybook package version in package.json was listed as fixed (7.6.7). This meant that we didn't allow any minor version updates, as well as patch version updates, which often include security vulnerabilities/patches. The latter is actually exactly the case, since version 7.6.7 had ws@6.2.2 package listed as a dependency, which in turn has a known high risk vulnerability.

├─┬ storybook@7.6.7
│ └─┬ @storybook/cli@7.6.7
│   ├─┬ @storybook/core-server@7.6.7
│   │ └── ws@8.16.0
│   └─┬ puppeteer-core@2.1.1
│     └── ws@6.2.2

In regards to above, here's the console output of npm list ws AFTER updating Storybook

├─┬ storybook@7.6.20
│ └─┬ @storybook/cli@7.6.20
│   ├─┬ @storybook/core-server@7.6.20
│   │ └── ws@8.18.0
│   └─┬ puppeteer-core@2.1.1
│     └── ws@6.2.3 // <--- security vulnerability patched

Changes

Added

Changed

Storybook version was changed to 7.6.20 (same minor version, but latest patch)
^ (carret) was added in front of the version to allow future minor and patch updates

Deprecated

Removed

Fixed

Security

Testing

As long as CI passes successfully, I think we should give Storybook a quick smoke test (i.e. check a couple of stories, docs, actions, controls, links etc) to verify that nothing broke (technically, everything should be intact, since it's just a patch version update).

Changes can be tested via Pre-release

In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

github-actions[bot] commented 2 months ago

Published Pre-release for 02740c34146105977332ef53f29c4e6abd9ba637 with versions:

  - @jobber/components@5.36.1-update-sto-02740c3.4+02740c34

To install the new version(s) for Web run:

npm install @jobber/components@5.36.1-update-sto-02740c3.4+02740c34

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying atlantis with Cloudflare Pages

Latest commit:	`c50aef5`
Status:	✅ Deploy successful!
Preview URL:	https://a78fb2ae.atlantis.pages.dev
Branch Preview URL:	https://update-storybook-to-latest-p.atlantis.pages.dev

View logs

nad182 commented 1 month ago

To install the pre-release version in JO or JF, please run npm install @jobber/components@5.36.1-update-sto-02740c3.4 (or pnpm install).

GetJobber / atlantis