GetJobber / atlantis

🔱 Atlantis
https://atlantis.getjobber.com
MIT License
27 stars 30 forks source link

docs(components): use semantic colors in `SelectableChip` story #2051

Closed chris-at-jobber closed 1 month ago

chris-at-jobber commented 1 month ago

Motivations

Story for Selectable Chip did not work in dark mode

Before: image

After: image

Changes

Changed

Fixed

image image

Testing

Review SelectableChip story locally or on Cloudflare build


In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2d7654b
Status: âœ…  Deploy successful!
Preview URL: https://16be2e95.atlantis.pages.dev
Branch Preview URL: https://update-internal-chip-colors.atlantis.pages.dev

View logs

chris-at-jobber commented 1 month ago

@nad182 pushed up the braces change! In terms of the color change, I have confirmed that there are currently 0 usages of ChipSelectable in jobber or frontend, and no imports within other Atlantis components outside of the component itself, so I am confident that

image

image

image