GetJobber / atlantis

šŸ”± Atlantis
https://atlantis.getjobber.com
MIT License
27 stars 30 forks source link

feat(components): BREAKING CHANGE: remove Civil Date and Time libraries #2091

Closed JeffMarvin closed 1 week ago

JeffMarvin commented 1 month ago

Motivations

We should remove this long-since deprecated, never intended for production proposal library. With it, CivilDate, CivilTime and CivilDateTime are no longer valid data types for the components that used to use them. JavaScript Date objects work well enough as a standard for now, and things should improve in the language soon.

The following web components have their APIs affected:

InputTime required the use of CivilTime (and didn't have other types available as input values) and is the least compatible with this change.

This also cleans up an unused polyfill (time-input-polyfill) that was originally introduced to make InputTime compatible with Safari.

Changes

Added

Changed

Deprecated

Removed

Fixed

Security

Testing

Changes can be tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

github-actions[bot] commented 1 month ago

Published Pre-release for 79c3693bd040a7c73b62958741b365dbd406a585 with versions:

  - @jobber/components@5.46.1-JEFFMremo-79c3693.21+79c3693b

To install the new version(s) for Web run:

npm install @jobber/components@5.46.1-JEFFMremo-79c3693.21+79c3693b
cloudflare-workers-and-pages[bot] commented 4 weeks ago

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: f21d3ba
Status: āœ…  Deploy successful!
Preview URL: https://397d8b22.atlantis.pages.dev
Branch Preview URL: https://jeffm-remove-civil-date-time.atlantis.pages.dev

View logs