chore: Add CI jobs for new docs site & uncommitted files

[jdeichert]

Motivations

This PR adds 2 new jobs:

• Builds the new docs site to verify it doesn't fail. This will prevent us from accidentally breaking it.
• Post-build of everything, the second new job will verify the git tree doesn't contain any uncommitted changes. This will catch cases where we forget to commit generated files, such as package-lock.json or the new docs site prop files.

I also fixed npm run build in the new site package. npm run dev worked, but when we run build it produces a production bundle and checks for both typescript and vite errors.

• Fix for TS: https://github.com/GetJobber/atlantis/pull/2094/commits/467d64b99fe3e919ee3bb4618fdaad961ebbf6fc
• Fix for Vite: https://github.com/GetJobber/atlantis/pull/2094/commits/b86b7826280960318625442fe1caf17be33c0c34

Changes

Added

• New CI job to verify new docs site builds properly
• New CI job to verify we're committing generated files that are expected

Changed

• Updated eslint at the root to report unused directives

Removed

• Unnecessary CI step for npmrc file

Fixed

• TypeScript build errors in the new docs site (run via npm run build)
• Vite build issues due to missing alias for formatters package (run via npm run build)
• Lint warnings

Testing

CI passes this PR, the jobs are working as expected. You can view the latest runs here:

• build_new_docs
• check_git_status
  • See this comment for a failed run

To test the build commands work locally:

• pull this branch, npm ci at the root
• cd packages/site
• npm run dev - should start vite's dev server and open a browser window for the new docs site
• npm run build - should successfully build the site, output should look like this screenshot:

[cloudflare-workers-and-pages[bot]]

Deploying atlantis with    Cloudflare Pages

Latest commit:	f02110c
Status:	✅  Deploy successful!
Preview URL:	https://2711f04b.atlantis.pages.dev
Branch Preview URL:	https://jacob-lint-for-generated-fil.atlantis.pages.dev

View logs