fix(design): Updated CSS selectors for dark scrollbar colour [JOB-108461]

Beccaneer commented 4 weeks ago

Motivations

We wanted to move away from using ::-webkit-scrollbar as a CSS selector as it is considered non-standard (https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-scrollbar).

Unfortunately the change does not work on Safari, so the previous code remains for that case only. Safari's current behaviour seems to be on initial page load, the scrollbar is light but turns dark on subsequent page loads and this behaviour is unaffected by this change.

Fixed

Updated the CSS selector for the dark mode of the scrollbar for supported browsers

Testing

Turn on dark mode and check out the scrollbar 👀

Changes can be tested via Pre-release

Screenshots

Removed -- don't believe their lies

In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

github-actions[bot] commented 4 weeks ago

Published Pre-release for b84823926d95a14c0839e7c7b8a4d5a6918e7fa8 with versions:

  - @jobber/design@0.67.2-JOB-108461-b848239.31+b8482392

To install the new version(s) for Web run:

npm install @jobber/design@0.67.2-JOB-108461-b848239.31+b8482392

To install the new version(s) for Mobile run:

npm install @jobber/design@0.67.2-JOB-108461-b848239.31+b8482392

cloudflare-workers-and-pages[bot] commented 3 weeks ago

Deploying atlantis with Cloudflare Pages

Latest commit:	`b848239`
Status:	✅ Deploy successful!
Preview URL:	https://2e4d82f2.atlantis.pages.dev
Branch Preview URL:	https://job-108461.atlantis.pages.dev

View logs

GetJobber / atlantis