GetJobber / atlantis

🔱 Atlantis
https://atlantis.getjobber.com
MIT License
27 stars 30 forks source link

feat(docx): add disambiguation to a few components' Search #2109

Closed chris-at-jobber closed 1 week ago

chris-at-jobber commented 2 weeks ago

Motivations

It's common for less-universal components (ie not Button) to be known by different names. This makes it easier to find some of those components in our system, which is especially useful for newer consumers and contributors to adopt our nomenclature.

Inspiration from component.gallery image

Before "Looks like Atlantis doesn't have a pill component, guess I have to design one myself!" image

After "Ah I see one of these might be what I'm looking for" image

Additionally, search should be case-insensitive, so you can search "button" and see Button.

Before image image

After image

Changes

Added

Changed

Deprecated

Removed

Fixed

Security

Testing

Search for some of the terms in the "Additional Results" fields for each component

Search in upper and lower case

Changes can be tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

cloudflare-workers-and-pages[bot] commented 2 weeks ago

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: d37aba4
Status: âœ…  Deploy successful!
Preview URL: https://8c81f995.atlantis.pages.dev
Branch Preview URL: https://search-disambiguation.atlantis.pages.dev

View logs